[tempo-distributed] add missing probes #3907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkailantzis
requested review from
Sheikh-Abubaker,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
Signed-off-by: hkailantzis <[email protected]>
hkailantzis
force-pushed
the
add-missing-probes
branch
from
cd4306c to
19f01ab
Compare
Signed-off-by: hkailan <[email protected]>
|
hi @Sheikh-Abubaker , is there anything I have to do to trigger the Pending checks on this PR or these will be triggered from the reviewers manually ? Thanks in advance :-) |
hkailantzis
changed the title
Signed-off-by: hkailan <[email protected]>
…rafana-helm-charts into add-missing-probes
Signed-off-by: hkailantzis <[email protected]>
…rafana-helm-charts into add-missing-probes
|
There seems to be an issue with the DCO after a wrong edit/sign off. Will create a brand new PR. #3910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2966
Added the liveness probe on the 'common' scope (readiness was already there) and added the relevant probes, where they were missing.
Tested on local k8s cluster (minikube), by enabling metrics-generator and gateway component on top, to test their probes also. All relevant components started as expected.